Skip to content

Conversation

c-warren
Copy link
Contributor

@c-warren c-warren commented Oct 6, 2025

What changed?

Allow gpg signed commits to pass DCO checks

Why?

DCO has been introduced to verify that each commit in the repository has been signed-off by the developer who is committing it. There are two ways to do this:

  • `git commit -s -m "my message"
  • sign each commit with a gpg key

This PR allows both of these methods to pass the check, rather than just the first.

How did you test it?

In the cadence repo.

Potential risks

N/A

Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.20%. Comparing base (e52124b) to head (884a30a).
⚠️ Report is 1 commits behind head on master.
see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e52124b...884a30a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@c-warren c-warren merged commit 24b3e46 into cadence-workflow:master Oct 6, 2025
12 checks passed
gazi-yestemirova pushed a commit to gazi-yestemirova/cadence-go-client that referenced this pull request Oct 14, 2025
gazi-yestemirova added a commit that referenced this pull request Oct 14, 2025
* feat: Introduce FailoverDomain endpoint from cadence-idl

Signed-off-by: Gaziza Yestemirova <[email protected]>

* fix TestWorkflowExecutionContinuedAsNewEventAttributes

Signed-off-by: Gaziza Yestemirova <[email protected]>

* ci: Lint PR titles with Conventional Commmit standard (#1462)

<!-- Describe what has changed in this PR -->
**What changed?**

Adds a linter to ensure the conventional commit standard is used for PR titles.

<!-- Tell your future self why have you made these changes -->
**Why?**

See cadence-workflow/cadence@c4b6330 for more details.

<!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? -->
**How did you test it?**

In the cadence repo.

<!-- Assuming the worst case, what can be broken when deploying this change to production? -->
**Potential risks**

N/A

Signed-off-by: Chris Warren <[email protected]>
Signed-off-by: Gaziza Yestemirova <[email protected]>

* ci: Allow gpg signed commits to pass DCO checks (#1463)

Signed-off-by: Chris Warren <[email protected]>
Signed-off-by: Gaziza Yestemirova <[email protected]>

* Add endpoints for DomainClient

Signed-off-by: Gaziza Yestemirova <[email protected]>

* Update clusterName

Signed-off-by: Gaziza Yestemirova <[email protected]>

* Add another domain to fail over

Signed-off-by: Gaziza Yestemirova <[email protected]>

---------

Signed-off-by: Gaziza Yestemirova <[email protected]>
Signed-off-by: Chris Warren <[email protected]>
Co-authored-by: Chris Warren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants